Skip to content

[GUI] Dashboard, include owner cold stakes in the chart.#1361

Merged
Fuzzbawls merged 1 commit into
PIVX-Project:masterfrom
furszy:2020_include_owner_cold_stakes
Mar 4, 2020
Merged

[GUI] Dashboard, include owner cold stakes in the chart.#1361
Fuzzbawls merged 1 commit into
PIVX-Project:masterfrom
furszy:2020_include_owner_cold_stakes

Conversation

@furszy
Copy link
Copy Markdown

@furszy furszy commented Feb 27, 2020

Auto-descriptive PR.

Include missing cold stakes in the staking chart if the wallet is the cold staking owner (Didn't add the hot side because the chart is showing the wallet's received "staking rewards" and the hot wallet is not the utxo owner, just staked in behalf of the owner).

Fuzzbawls
Fuzzbawls previously approved these changes Mar 2, 2020
Copy link
Copy Markdown
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86731dd

Comment thread src/qt/transactionfilterproxy.cpp Outdated
@random-zebra random-zebra added this to the 4.1.0 milestone Mar 2, 2020
@furszy furszy force-pushed the 2020_include_owner_cold_stakes branch from 86731dd to 4901d75 Compare March 2, 2020 23:39
@furszy
Copy link
Copy Markdown
Author

furszy commented Mar 2, 2020

updated per @random-zebra's feedback.

@furszy furszy requested review from Fuzzbawls and random-zebra March 2, 2020 23:53
@random-zebra
Copy link
Copy Markdown

Definitely better and straightforward change. 👍 Code ACK.
Going to run some test.

Copy link
Copy Markdown

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4901d75

Copy link
Copy Markdown
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good simplification.

ACK 4901d75

@Fuzzbawls Fuzzbawls merged commit 0a613c0 into PIVX-Project:master Mar 4, 2020
@furszy furszy deleted the 2020_include_owner_cold_stakes branch November 29, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants