[WIP][GUI] Include MN Rewards in the dashboard chart.

[furszy]

Describing this work briefly:
As we don't have zPIV staking anymore, this PR removes it from the dashboard chart and includes the Masternodes rewards instead.

It was coded on top of #1361 (first commit doesn't count and we need to merge that PR first).

TODO:
Rename variable names from zpiv-something to MN instead in the dashboard file.

[Fuzzbawls]

needs rebase

[Liquid369]

I have something similar if we want to compare how I have it done to record masternode and stakes in charts.
I noticed you inserted MNReward tags for some but put in ZPiv for others than PIV. Trivial changes ie;

Line 137 in dashboardwidget.cpp
this->fShowZpivStakes = fIncludeZPIV;
this->fIncludeMNReward = fIncludeMNReward;

Maybe collaborate on finishing this up with you.
Had worked on this previously with @akshaynexus

A quick cleanup changing the ZPiv used titles and calculations would suffice mostly for this instance

Are you keeping the ZPiv for the 5.0 update?

I see adding some options like fShowZpivStakes

I am sure you have a better logic behind yours vs mine but I can help here.

[furszy]

Hello.
The object names can be easily be changed, not really a concern for now.

I left it under WIP for performance concerns over big controller wallets. We need to improve the tx filter used in the chart before include another set of data income there.

[decenomy]

Hi @furszy, we already have this feature implemented, and we can share it with you.

[furszy]

Hey hello @decenomy, a bit of context here:
I left this feature in stand-by not because it's difficult to implement, because when i did it, the 4.xx version of our software wasn't performant, and stable, enough in the GUI area and the MNs rewards inclusion in the chart filter was being perjudicial for the overall software experience.

Now.. standing in v5.2 and after all the changes that did for v5.xx (#2203, #2082, #2118, #2150, #2192, #2195, etc etc) the overall software responsiveness is in a much better state to get this one rebased and merged. But.. there is one more task that will be nice do to before moving forward with this feature.
Need to replace/rework the QT filter that is currently being used in the chart load (which essentially recalculates the entire chart presented information on every refresh) for one customly made with a cache system and signal based update (this will solve a current segfault, inside the QT filter class, that use to happen on large wallets during sync).

[furszy]

superseded by #2577. Closing.