Conversation
Extracted from dt10_development to make it easier to merge back into 1.0.0-alpha to check on parsing progress.
- gals_heat used sin. Patched to approximation. - relaxation_heat used exit. Patched to fake_handler_exit - Skipping all tests involving externals.
- TODO patch filtering back in based on level
- TODO: explicitly set log level.
Graph was missing fanin property on finished node, so never terminated.
heliosfa
left a comment
heliosfa
left a comment
There was a problem hiding this comment.
All seems to work as expected. I note that this does not include and curly brace detection, so I have updated all of the examples for these changes (related PR: POETSII/Orchestrator_examples#11) and tested.
I have also updated the applications documentation and examples (POETSII/orchestrator-documentation#21) and tested.
I have not performed any timing tests. It should be noted that there may still be some Soton XML (I am thinking Third year projects) that has not been updated for these changes.
We should produce some documentation for the testing suite.
I have emailed @kdalal2000 about this. |
3 participants
This is a re-packaging of the v4 parsing patches proposed last month, which
should merge straight onto the current development branch.
The main purpose is to just get the PIP20 v4 XML parsing and running.
It contains the test suite and reference XML I suggested
previously in #208, but I get the impression there is some reluctance to
have unit tests in the Orchestrator? So if having tests in the Orchestrator repo
is blocking merging, then just strip them out and take just the syntax patches.
I can just maintain my own orchestrator test-suite somewhere else (though I
still really don't understand how you develop and maintain something like
the Orchestrator without a good test suite).