Merged
Conversation
mvousden
approved these changes
Jun 28, 2021
Contributor
mvousden
left a comment
mvousden
left a comment
There was a problem hiding this comment.
This changeset:
- Moves the
netstressexample into the Mothership diagnosis examples suite. - Removes
sup_ping, as it is superseded by another example. - Updates the
PandSattributes for device and edge instances to mandatorily include curly braces in the definition.
One minor comment in test_supervisor_send, but otherwise all is well.
| @@ -0,0 +1,250 @@ | |||
| <?xml version="1.0"?> | |||
| <Graphs xmlns="" appname="NetStress"> | |||
Contributor
There was a problem hiding this comment.
The appname and ids should match the naming pattern of other XML in the directory, if possible.
Collaborator
Author
That was not meant to be an outcome of this PR. I have a feeling I have committed a superfluous file. |
Collaborator
Author
|
I have run a fair few of the examples on hardware with the changes and they all run as expected. I have not performed any timing tests. |
Contributor
|
I maintain my approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to POETSII/Orchestrator#264 by updating all of the examples to work with the tweaks to the v4 parser.
Testing so far has involved running through the Orchestrator up to and including composition. Generated output has been inspected for correctness. Hardware testing will be carried out on Monday.
@m8pple don't feel like you have to review - i have only added you as this is related to your PR.