Blapping the last of the warnings - fixing #31

[heliosfa]

This PR addresses the remaining warnings left over from #31 and adds the -pedantic flag to the make file.

This means that a make -j X -s is now completely silent on POETS Boxes (GCC 7.3.0):

gmb@heaney:~/Orchestrator/Build/gcc$ make clean
if [ -d "../../application_staging" ]; then \
        find "../../application_staging" \
                ! -regex '../../application_staging/xml.*' \
                ! -wholename "../../application_staging" \
                -exec rm --force --recursive {} +; \
fi
rm --force --recursive ./Objects ./Dependency_lists ../../bin \
../../orchestrate.sh ../../test_bin
gmb@heaney:~/Orchestrator/Build/gcc$ make -j 12 -s
gmb@heaney:~/Orchestrator/Build/gcc$

@mvousden also tested on GCC 9.1.0 and I have tested on GCC 6.3.0

Testing carried out:

• make tests and then ./run-tests.sh passes

gmb@heaney:~/Orchestrator/test_bin$ ./run-tests.sh
Running all tests...
All tests passed.
Running memory checks on all tests...
All memory checks passed.

• A 40x40 heated plate builds, deploys, executes and completes correctly.
• A 280x280 heated plate builds, deploys, executes and completes correctly.

[mvousden]

Still builds silently on GCC 9.1.0 post-merging-in-development.

I guess you still plan to add -Werror - please do so.

[heliosfa]

As per quick chat with @mvousden, we are leaving -Werror off for the time being - it will be selectively enabled for CI.

As a general rule, things with warnings won't be accepted for merge.