Fixes/tests from virtualship development at EDITO hackathon#2348
Merged
erikvansebille merged 17 commits intov4-devfrom Oct 31, 2025
Merged
Fixes/tests from virtualship development at EDITO hackathon#2348erikvansebille merged 17 commits intov4-devfrom
erikvansebille merged 17 commits intov4-devfrom
Conversation
But work on v4-dev itself. Need to explore further
erikvansebille
added a commit
to Parcels-code/virtualship
that referenced
this pull request
Oct 24, 2025
Requires Parcels-code/Parcels#2348 to work
Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com>
VeckoTheGecko
approved these changes
Oct 31, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good, just want one clarification on clipping
Contributor
|
Good to merge - can we update the description of the PR body with a bullet list to enumerate the changes made? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has some extra unit tests, fixes and migration guide updates that were found during the EDITO hackathon work on VirtualShip. Most important ones
Grid.depthis not monotonically increasing