Skip to content

Conversation

@ramonsmits
Copy link
Member

No description provided.

@ramonsmits ramonsmits self-assigned this Oct 3, 2023
static long DataSize(RavenDBPersisterSettings settings)
{
var datafilePath = Path.Combine(settings.DatabasePath, "data");
var datafilePath = Path.Combine(settings.DatabasePath, "Databases", settings.DatabaseName, "Raven.voron");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database is more than that file. One database that grows large enough can have multiple data files in it, and the Indexes directory has a directory for each index which each have their own Raven.voron file as well. For production systems those index directories will also get quite large.

Suggested change
var datafilePath = Path.Combine(settings.DatabasePath, "Databases", settings.DatabaseName, "Raven.voron");
var datafilePath = Path.Combine(settings.DatabasePath, "Databases", settings.DatabaseName);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, Voron uses a single file and I missed the bit about this being only for the Database file size, and that the Database Folder Size covered what I was thinking of.

static long DataSize(RavenDBPersisterSettings settings)
{
var datafilePath = Path.Combine(settings.DatabasePath, "data");
var datafilePath = Path.Combine(settings.DatabasePath, "Databases", settings.DatabaseName, "Raven.voron");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, Voron uses a single file and I missed the bit about this being only for the Database file size, and that the Database Folder Size covered what I was thinking of.

@DavidBoike DavidBoike merged commit f0b241c into master Oct 3, 2023
@DavidBoike DavidBoike deleted the DataSize branch October 3, 2023 15:33
@DavidBoike DavidBoike added this to the 5.0.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants