Skip to content

Path was still based on RavenDB 3.5 implementation, updated to use RavenDB 5 voron location #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidBoike merged 1 commit into from
Oct 3, 2023
Merged

Path was still based on RavenDB 3.5 implementation, updated to use RavenDB 5 voron location #3725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ServiceControl.Persistence.RavenDb5/EmbeddedDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ static void RecordStartup(RavenDBPersisterSettings settings)

static long DataSize(RavenDBPersisterSettings settings)
{
var datafilePath = Path.Combine(settings.DatabasePath, "data");
var datafilePath = Path.Combine(settings.DatabasePath, "Databases", settings.DatabaseName, "Raven.voron");
Copy link
Member

@DavidBoike DavidBoike Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database is more than that file. One database that grows large enough can have multiple data files in it, and the Indexes directory has a directory for each index which each have their own Raven.voron file as well. For production systems those index directories will also get quite large.

Suggested change
var datafilePath = Path.Combine(settings.DatabasePath, "Databases", settings.DatabaseName, "Raven.voron");
var datafilePath = Path.Combine(settings.DatabasePath, "Databases", settings.DatabaseName);

Copy link
Member

@DavidBoike DavidBoike Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, Voron uses a single file and I missed the bit about this being only for the Database file size, and that the Database Folder Size covered what I was thinking of.


try
{
Expand Down