Check for removed transports, and deduplicate all other install checks #3808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify them, only need 1 copy of license check code
…ow can be injected again
4 tasks
tmasternak
approved these changes
Nov 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a concept to show that Azure Service Bus Legacy and the old RabbitMQ transports are removed, and a check so that if the transport is removed and doesn't have an auto-upgrade path, it can't be installed/upgraded.
A lot of the pre-install and pre-upgrade checks were scattered and duplicated all over. This centralizes all those checks.
However, this PR does not do a similar dedupe process on the PowerShell cmdlets.