Force upgrade for audit instance and added force upgrade to Powershell #3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
changed the title
5 tasks
ramonsmits
commented
Nov 9, 2023
src/ServiceControl.Management.PowerShell/Cmdlets/AuditInstances/InvokeAuditUpgrade.cs
Outdated
Show resolved
Hide resolved
DavidBoike
reviewed
Nov 10, 2023
src/ServiceControl.Config/Commands/ForceUpgradeAuditInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Config/Commands/ForceUpgradeAuditInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Config/Commands/ForceUpgradeAuditInstanceCommand.cs
Outdated
Show resolved
Hide resolved
| DisableFullTextSearchOnBodies = DisableFullTextSearchOnBodies, | ||
| UpgradeInfo = | ||
| UpgradeControl.GetUpgradeInfoForTargetVersion(installer.ZipInfo.Version, instance.Version), | ||
| UpgradeInfo = UpgradeControl.GetUpgradeInfoForTargetVersion(installer.ZipInfo.Version, instance.Version), |
Member
There was a problem hiding this comment.
Note that the continued references to installer.ZipInfo.Version are silly. Every installer and zip available in the app is going to be the same version, and that version is easily accessible using Constants.CurrentVersion. Using the installer for that just makes all this code harder to refactor.
Member
Author
There was a problem hiding this comment.
The code doesn't compile on this so I just removed this whole line
ramonsmits
force-pushed
the
force-upgrade-audit-and-powershell
branch
from
1fdacdc to
f021a4a
Compare
tmasternak
previously requested changes
Nov 13, 2023
src/ServiceControl.Management.PowerShell/Cmdlets/AuditInstances/InvokeAuditUpgrade.cs
Outdated
Show resolved
Hide resolved
...Management.PowerShell/Cmdlets/ServiceControlInstances/InvokeServiceControlInstanceUpgrade.cs
Outdated
Show resolved
Hide resolved
1 task
DavidBoike
force-pushed
the
force-upgrade-audit-and-powershell
branch
from
f021a4a to
52cf898
Compare
DavidBoike
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke-ServiceControlAuditInstanceUpgradeandInvoke-ServiceControlInstanceUpgradenow have-ForceRecreateDatabaseswitch. When set the database path will be moved and the persister manifest will be forced to the latest Raven engine.Forceswitch