Skip to content

Conversation

@tmasternak
Copy link
Member

@tmasternak tmasternak commented Nov 13, 2023

@tmasternak tmasternak changed the title Stop supporting !disable as a valid error/audit queue name value Drop support for !disable as a valid error/audit queue name value Nov 13, 2023
@ramonsmits ramonsmits changed the base branch from master to force-upgrade-audit-and-powershell November 13, 2023 12:25
Copy link
Member

@ramonsmits ramonsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 just minor comment to rename a property to align settings keys with code

@DavidBoike DavidBoike force-pushed the force-upgrade-audit-and-powershell branch from f021a4a to 52cf898 Compare November 13, 2023 19:25
Base automatically changed from force-upgrade-audit-and-powershell to master November 13, 2023 20:02
@DavidBoike DavidBoike force-pushed the remove-disable-as-queue-name branch from bdf8d7a to 609fff1 Compare November 13, 2023 20:06
@tmasternak tmasternak changed the title Drop support for !disable as a valid error/audit queue name value Switch from !disable to dedicated settings to disable error/audit queue ingestion Nov 14, 2023
@DavidBoike DavidBoike merged commit c7bff2d into master Nov 14, 2023
@DavidBoike DavidBoike deleted the remove-disable-as-queue-name branch November 14, 2023 16:06
@DavidBoike DavidBoike added this to the 5.0.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants