-
Notifications
You must be signed in to change notification settings - Fork 282
Replace {RCurl} with {curl} #2944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't know what to enter in the "type" argument and I am still not sure that form_file is the ideal function to replace the POSTFORM function.
This reverts commit 4bc6721.
Member
Author
|
Leaving two usages of RCurl in |
Member
Author
|
Ready for review. Please squash when merging. |
mdietze
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #2786, in which @moki1202 made a good start on replacing all calls to the
RCurlpackage with the closest equivalents from the (newer, better designed, more actively maintained)curlpackage. I'm continuing the work here rather than in that branch because I gave him such bad advice about both RCurl and about git that it became my problem to fix it 😉 🙈Still in progress, but pushing as a draft for visibility. Please squash-merge when it's time.
Description
Motivation and Context
Review Time Estimate
Types of changes
Checklist: