Skip to content

Conversation

@infotroph
Copy link
Member

@infotroph infotroph commented Jun 23, 2022

This is a replacement for #2786, in which @moki1202 made a good start on replacing all calls to the RCurl package with the closest equivalents from the (newer, better designed, more actively maintained) curl package. I'm continuing the work here rather than in that branch because I gave him such bad advice about both RCurl and about git that it became my problem to fix it 😉 🙈

Still in progress, but pushing as a draft for visibility. Please squash-merge when it's time.

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph
Copy link
Member Author

Leaving two usages of RCurl in gSSURGO.Query because they conflict with changes in #2964. Will include the conversion of those are part of that PR.

@infotroph infotroph marked this pull request as ready for review September 25, 2022 04:27
@infotroph
Copy link
Member Author

Ready for review. Please squash when merging.

@infotroph infotroph requested a review from moki1202 September 26, 2022 07:04
@mdietze mdietze merged commit d13b60a into PecanProject:develop Sep 26, 2022
@infotroph infotroph deleted the replace-rcurl branch November 3, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants