Update gSSURGO queries after apparent API changes #2964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotroph
added a commit
to infotroph/pecan
that referenced
this pull request
Sep 24, 2022
13 tasks
mdietze
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Update convert.input.R don't know what to enter in the "type" argument and I am still not sure that form_file is the ideal function to replace the POSTFORM function. * Update download.url.R * Update met.process.R * Update download.NLDAS.R * Update download.GLDAS.R * Update extract_soil_nc.R * Update LandTrendr.AGB.R * Update land.utils.R * Update salix_benchmarks.Rmd * Update convert.input.R * Update convert.input.R * Update browndog.R * Update met.process.R * Update DESCRIPTION * Update abbreviated_workflow_SIPNET.R * Update workflow.bm.R * Update workflow.pda.R * Update workflow.wcr.assim.R * Update workflow.R * Update DESCRIPTION * Update DESCRIPTION * Update pecan.depends.R * Update running_maat_in_pecan.Rmd * Update graph_fluxtowers.R * Update graph_SDA_fluxtowers.R * Update workflow.template.R * Update DESCRIPTION * Update DESCRIPTION * Update LoadFLUXNETsites.R * Update LoadPalEONsites.R * curl calls in PEcAn.utils, plus argument fix in download.url * viz was declaring (RC|c)url without using + reorder deps * Revert "Update browndog.R" This reverts commit 95b8dc7: Everything in the contrib/ folder is no longer supported and is provided without updates. * Revert "Update graph_SDA_fluxtowers.R" This reverts commit 7789db7. * Revert "Update graph_fluxtowers.R" This reverts commit 7864b50. * Revert "Update workflow.template.R" This reverts commit 6c3df94. * Revert "Update LoadFLUXNETsites.R" This reverts commit 8c64719. * Revert "Update LoadPalEONsites.R" This reverts commit 4bc6721. * remove unneeded library calls * typo * typos * Remove stray lines describing unrelated function * roxygen * handle is already a connection * fix curl_download call in download.LandTrendr.AGB * fix curl_download in get.elevation * fix browndog POST in met.process * whitespace * declare curl in data.atm * remove unused RCurl load * typo * sort * db description * leave RCurl n SSURGO calls; will fix in #2964 * update import count Co-authored-by: Shashank Singh <73598347+moki1202@users.noreply.github.com>
mdietze
approved these changes
Sep 26, 2022
Merged
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what exactly changed or when in the gSSURGO API, but I was not able to make
gSSURGO.Queryorextract_soil_ncwork in their current form -- this is my attempt to reverse-engineer a fix.Input requested especially on my big deletion in
extract_soil_nc, which completely drops the use of gdal in favor of asking the API to only return the mukeys in the first place. If there's a reason the gdal steps were necessary, please educate me!