Skip to content

Adds crafting recipes for the new guns, and makes legacy guns uncraftable#355

Closed
genessee-forgot-his-password-again wants to merge 28 commits intoPersistentSS13:devfrom
genessee-forgot-his-password-again:craftable-guns
Closed

Adds crafting recipes for the new guns, and makes legacy guns uncraftable#355
genessee-forgot-his-password-again wants to merge 28 commits intoPersistentSS13:devfrom
genessee-forgot-his-password-again:craftable-guns

Conversation

@genessee-forgot-his-password-again
Copy link
Contributor

Description of changes

This PR makes the guns added last week all craftable using the RnD system by giving them designs. It also adds bogus designs to existing legacy guns to make them uncraftable.

Some minor tweaks were done to the new guns - for example, the golden pistol had it's material tech lowered from 10 to 5, and the Footman rifle's w_class was increased from large to huge.

Why and what will this PR improve

People being able to craft the new guns is good so admins don't have to shower them upon the masses like gifts from above.

People not being able to craft the legacy guns ensure balance is kept so that players actually go about using the guns added, and so that we're not just crossing our fingers hoping the Nebula-balanced guns also work here (as we can't modify them very easily)

Authorship

Joe Mama for moral support
genessee for code

Changelog

🆑
add: An assortment of guns are now craftable via RND
tweak: The Footman rifle is now huge instead of bulky
tweak: The Midas pistol now requires a lower materials tech to craft
fix: The legacy guns from Nebula are no longer craftable via RND
/:cl:

@genessee-forgot-his-password-again
Copy link
Contributor Author

SUCCESS!!!

Copy link
Collaborator

@PsyCommando PsyCommando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@PsyCommando
Copy link
Collaborator

Uh, just wondering are you still adding files with the upload feature? Because that's what completely broke everything even the server working copy.

@genessee-forgot-his-password-again
Copy link
Contributor Author

yeah i've been uploading stuff, what should i do instead

@PsyCommando
Copy link
Collaborator

yeah i've been uploading stuff, what should i do instead

Well, get github desktop at least. Then clone your fork on you computer using github desktop. So from there, once you make changes to the files, you can commit them and then push them to your fork. Then you can PR your fork. That's definitely going to fix the broken tracked files issues that uploading files to github seems to cause.

@PsyCommando
Copy link
Collaborator

You probably don't want to look at this branch or the other one from the other PR your computer though, because they're gonna fuck your local copy.

@PsyCommando
Copy link
Collaborator

@NataKilar Just wanted to know your thoughts on this? Should we attempt merging it even if there's a chance the untracked files will break everything again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ℹ️ question Further information is requested 🆕 enhancement New feature or request ⚠️ merge conflict Resolve conflicts manually

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants