Makes the New Guns Acquirable via RND + Reformats Gun Naming Scheme#461
Merged
NataKilar merged 43 commits intoPersistentSS13:devfrom Jul 18, 2023
Merged
Conversation
Contributor
Author
|
ah shit i didn't do it in github desktop which is why my thing got denied in the first place oooooops!!!! |
Contributor
Author
|
okay i think i fixed it |
Contributor
Author
|
not really sure why map tests are failing |
Contributor
Author
|
updated the naming format |
genessee-forgot-his-password-again
changed the title
Contributor
Author
|
oh hey look i fixed it |
NataKilar
requested changes
Jul 18, 2023
NataKilar
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Does a (hopefully) functional version of what I tried to do in #355 - see there for the actual changes listed out.
In addition to those changes, this PR also improves the gun names and descriptions to provide more useful information such as caliber and a brief description of the guns' weaknesses.
Why and what will this PR improve
Makes the assortment of new guns obtainable in-game.
Also makes legacy guns uncraftable, as they cannot be removed without fooling with stuff outside the modpack.
Having this new naming format for guns makes them more immediately useful to people who don't know, for example, what caliber the weapon needs. Also makes them less of a text-wall trap to examiners.
Authorship
genessee made this
Changelog
🆑
add: An assortment of guns are now craftable via RND
tweak: The Footman rifle is now huge instead of bulky
tweak: The Midas pistol now requires a lower materials tech to craft
tweak: All firearms now have a more concise naming and description format
fix: The legacy guns from Nebula are no longer craftable via RND
/:cl: