Allow binning if PARAM_BINNING_* is not defined#56
Merged
tomhanak merged 1 commit intoPhotometrics:masterfrom Jun 4, 2025
Merged
Allow binning if PARAM_BINNING_* is not defined#56tomhanak merged 1 commit intoPhotometrics:masterfrom
tomhanak merged 1 commit intoPhotometrics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
The Photon Max 512 supports arbitrary binning sizes, but because it doesn’t expose
PARAM_BINNING_SERorPARAM_BINNING_PAR, PyVCAM currently blocks any calls to setbin_Xorbin_Y.This PR updates the binning‐validation logic so that if those properties are missing, we simply skip the range check and allow arbitrary binning.
I’ve only been able to test this on the Photon Max 512, so I’m not certain how it might affect other models. Any feedback or suggestions on potential side effects would be greatly appreciated!
Thanks for reviewing.