Skip to content

Allow binning if PARAM_BINNING_* is not defined #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomhanak merged 1 commit into from
Jun 4, 2025
Merged

Allow binning if PARAM_BINNING_* is not defined #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/pyvcam/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,10 @@ def bin_x(self):
@bin_x.setter
def bin_x(self, value):
# Will raise ValueError if incompatible binning is set
if value in self.read_enum(const.PARAM_BINNING_SER).values():
if (
not self.check_param(const.PARAM_BINNING_SER) or
value in self.read_enum(const.PARAM_BINNING_SER).values()
):
for roi in self.__rois:
roi.sbin = value
return
Expand All @@ -868,7 +871,10 @@ def bin_y(self):
@bin_y.setter
def bin_y(self, value):
# Will raise ValueError if incompatible binning is set
if value in self.read_enum(const.PARAM_BINNING_PAR).values():
if (
not self.check_param(const.PARAM_BINNING_PAR) or
value in self.read_enum(const.PARAM_BINNING_PAR).values()
):
for roi in self.__rois:
roi.pbin = value
return
Expand Down