Conversation
|
@BriceSD, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @TheSavior and @Quantra to be potential reviewers |
|
|
||
| while True: | ||
| bot.tick() | ||
| inventory.refresh_inventory() |
There was a problem hiding this comment.
Is this trigger API protocol call to contact server?
There was a problem hiding this comment.
Yes it does. Once we got our new map we’ll get rid of this.
There was a problem hiding this comment.
You mean the local file server or The Niantic server?
There was a problem hiding this comment.
Niantic server inventory = self.bot.api.get_inventory().
There was a problem hiding this comment.
The mobile app contact server every 10s as know as the heartbeat, we should not change the api sequence. Even now, we have much work to refactor the call sequence.
There was a problem hiding this comment.
An other solution could be to add something like inventory.to_json(). This way we wouldn’t need to make a call to the server.
But this seems pretty annoying to do. Definitely not on top of my priority list, I won’t do it myself.
Oohhh so that’s what hearbeat represent
There was a problem hiding this comment.
ok, so we are good here :)
There was a problem hiding this comment.
Could also move this to the heartbeat method. It’s up to you.
There was a problem hiding this comment.
Should be in the heartbeat function, not everyone uses the webui and not everyone should have to suffer a potential ban by doing api calls every tick because of a small minority who want a fancy gui
|
We'd better compare the MITM package with real app. To understand what do they including in the heartbeat. |
|
Closed in favour of #4513 |
4 participants
Short Description:
Now update again web inventory
Fixes/Resolves/Closes :