Skip to content

Update web inventory at every tick #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BriceSD wants to merge 1 commit into from
Closed

Update web inventory at every tick #4507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pokecli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ def get_commit_hash():

while True:
bot.tick()
inventory.refresh_inventory()
Copy link
Contributor

@solderzzc solderzzc Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this trigger API protocol call to contact server?

Copy link
Member Author

@BriceSD BriceSD Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does. Once we got our new map we’ll get rid of this.

Copy link
Contributor

@solderzzc solderzzc Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the local file server or The Niantic server?

Copy link
Member Author

@BriceSD BriceSD Aug 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niantic server inventory = self.bot.api.get_inventory().

Copy link
Contributor

@solderzzc solderzzc Aug 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mobile app contact server every 10s as know as the heartbeat, we should not change the api sequence. Even now, we have much work to refactor the call sequence.

Copy link
Member Author

@BriceSD BriceSD Aug 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An other solution could be to add something like inventory.to_json(). This way we wouldn’t need to make a call to the server.
But this seems pretty annoying to do. Definitely not on top of my priority list, I won’t do it myself.

Oohhh so that’s what hearbeat represent

Copy link
Contributor

@solderzzc solderzzc Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so we are good here :)

Copy link
Member Author

@BriceSD BriceSD Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also move this to the heartbeat method. It’s up to you.

Copy link
Contributor

@k4n30 k4n30 Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in the heartbeat function, not everyone uses the webui and not everyone should have to suffer a potential ban by doing api calls every tick because of a small minority who want a fancy gui


except KeyboardInterrupt:
bot.event_manager.emit(
Expand Down