Merged
Conversation
abelfodil
force-pushed
the
refactor-d3-component
branch
from
9e4d222 to
3755468
Compare
| static propTypes = { | ||
| callback: PropTypes.func.isRequired, | ||
| } | ||
| const D3Component = React.memo(({ callback }) => { |
Contributor
There was a problem hiding this comment.
Use React.memo so we don't rerender when the parent does rerender with that same callback prop. We want that since D3 will handle DOM updates inside this svg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.