Skip to content

Refactor D3Component #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamHarvey97 merged 2 commits into from
Jun 21, 2020
Merged

Refactor D3Component #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3755468
Refactor D3Component to be a functional component
abelfodil Jun 18, 2020
44d8864
Use current attribute on React's ref to access svg el && avoid compon…
Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 7 additions & 21 deletions polydodo/src/components/d3component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,9 @@
import React from "react";
import PropTypes from "prop-types";
import React, { useEffect, useRef } from "react";

class D3Component extends React.Component {
static propTypes = {
callback: PropTypes.func.isRequired,
}
const D3Component = React.memo(({ callback }) => {
Copy link
Copy Markdown
Contributor

@WilliamHarvey97 WilliamHarvey97 Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use React.memo so we don't rerender when the parent does rerender with that same callback prop. We want that since D3 will handle DOM updates inside this svg.

const ref = useRef();
useEffect(() => callback(ref.current));
return <svg ref={ref} />;
});

componentDidMount() {
const { callback } = this.props;
callback(this.svg);
}

shouldComponentUpdate() {
return false;
}

render() {
return (<svg ref={ref => this.svg = ref } />);
}
}

export default D3Component;
export default D3Component;