fix: Debounce releases and skip empty tags in code workflow#1983
Merged
charlesvien merged 10 commits intomainfrom May 4, 2026
Merged
fix: Debounce releases and skip empty tags in code workflow#1983charlesvien merged 10 commits intomainfrom
charlesvien merged 10 commits intomainfrom
Conversation
Member
Author
This was referenced May 2, 2026
This was referenced May 3, 2026
e396426 to
b936821
Compare
9e4a4a8 to
231aed4
Compare
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
.github/scripts/compute-release-tag.sh:41
**`base_tag` output is never consumed**
The script outputs `base_tag=$LATEST_TAG` on stdout, but the workflow only parses `tag=` from `$RESULT` (via `grep '^tag='`). The `base_tag` line goes into `$RESULT` and is silently discarded. Per simplicity rule #4, this is a superfluous part — either remove the `base_tag` echo or consume it in the workflow (e.g. enrich the "Creating tag" log line).
### Issue 2 of 2
.github/scripts/compute-release-tag.test.sh:68-159
**Tests not parameterised**
Every test case repeats the same `setup_repo` → `run_script` → `assert_*` → `teardown_repo` pattern. The team convention is to prefer parameterised tests. A data-driven table of `(description, setup_commands, expected_exit, expected_stdout_contains, expected_stderr_contains)` tuples iterated by a single `run_test` function would eliminate the repetition and make adding new cases trivial.
Reviews (1): Last reviewed commit: "Harden test cleanup and TMPDIR fallback" | Re-trigger Greptile |
231aed4 to
ccfdb79
Compare
b936821 to
aaa1c0d
Compare
ccfdb79 to
ae2ccda
Compare
aaa1c0d to
833d5a4
Compare
jonathanlab
approved these changes
May 4, 2026
Contributor
jonathanlab
left a comment
There was a problem hiding this comment.
LGTM, lets try this and see if we like it
Member
Author
Merge activity
|
ae2ccda to
7ba8c45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Scheduled releases can fire mid stack merge (we all use Graphite) and the workflow crashes trying to create tags that already exist.
Changes
How did you test this?
I did not, we should make a simple ACT tooling setup to test this stuff easily.