Skip to content

fix: Reduce update check interval from 24h to 1h#1985

Merged
charlesvien merged 1 commit intomainfrom
05-02-reduce_update_check_interval_from_24h_to_1h
May 4, 2026
Merged

fix: Reduce update check interval from 24h to 1h#1985
charlesvien merged 1 commit intomainfrom
05-02-reduce_update_check_interval_from_24h_to_1h

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented May 3, 2026

Problem

The 24h update check interval causes users to download a stale update, restart and immediately see another update waiting. The client already re-checks even when an update is staged (periodic checks bypass the updateReady guard), but the 24h window is too long to catch newer versions before the user clicks restart.

NOTE: Since #1938, releases are batched on a 16h cadence instead of shipping on every merge, so it should no longer be the responsibility of the clients to scatter updates and we should actually want to pull the latest updates as soon as possible now because if we push a hotfix we want users to get it sooner than later and we are no longer spammy with our normal commit updates.

Changes

  1. Reduce CHECK_INTERVAL_MS from 24 hours to 1 hour
  2. Update test to match new interval

How did you test this?

Manually

@charlesvien charlesvien changed the title Reduce update check interval from 24h to 1h fix: Reduce update check interval from 24h to 1h May 3, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 3, 2026

Reviews (1): Last reviewed commit: "Reduce update check interval from 24h to..." | Re-trigger Greptile

@charlesvien charlesvien force-pushed the 05-02-reduce_update_check_interval_from_24h_to_1h branch from 91f2f49 to c1c1f34 Compare May 3, 2026 23:13
@charlesvien charlesvien force-pushed the 05-02-skip_empty_releases_in_code_tag_workflow branch 2 times, most recently from ccfdb79 to ae2ccda Compare May 4, 2026 01:38
@charlesvien charlesvien force-pushed the 05-02-reduce_update_check_interval_from_24h_to_1h branch from c1c1f34 to 8196799 Compare May 4, 2026 01:38
Copy link
Copy Markdown
Contributor

@jonathanlab jonathanlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

Copy link
Copy Markdown
Member Author

charlesvien commented May 4, 2026

Merge activity

  • May 4, 6:05 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 4, 6:30 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 4, 6:37 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien changed the base branch from 05-02-skip_empty_releases_in_code_tag_workflow to graphite-base/1985 May 4, 2026 18:17
@charlesvien charlesvien changed the base branch from graphite-base/1985 to main May 4, 2026 18:28
@charlesvien charlesvien force-pushed the 05-02-reduce_update_check_interval_from_24h_to_1h branch from 8196799 to db82e81 Compare May 4, 2026 18:29
@charlesvien charlesvien merged commit dd68bed into main May 4, 2026
16 checks passed
@charlesvien charlesvien deleted the 05-02-reduce_update_check_interval_from_24h_to_1h branch May 4, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants