-
Notifications
You must be signed in to change notification settings - Fork 57
Closed
Labels
Issue-EnhancementThe issue is a feature or ideaThe issue is a feature or idea
Description
Summary of the new feature / enhancement
In prior conversations and in the decomposed schema, I have the manifestVersion key in the resouce manifest documented as defining the version of the resource manifest schema that the manifest adheres to, requiring it to be semver and limited to the versions of the schema we support, which is currently 1.0.
A few things:
1.0isn't valid semver by the regex recommended on semver.org - it would have to be1.0.0(and should maybe more accurately be0.1.0)- I thought I remembered there being a check on this version in the code, but a quick check didn't turn one up.
- If this is actually referencing the canonical schema for the manifest, should this maybe just be the
$schemakey and point to the resource manifest schema's$id?
Proposed technical implementation details (optional)
Either:
- Update
manifestVersionto use a valid semantic version string, like0.1.0 - Replace
manifestVersionwith the$schemakeyword and require the specified schema to be one of the list of supported schemas.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Issue-EnhancementThe issue is a feature or ideaThe issue is a feature or idea
Type
Projects
Status
Done