change ManifestVersion to $schema and validate #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@michaeltlombardi I'm leaving it to you to update the schemas as a follow-up PR |
miroman9364
reviewed
Sep 20, 2023
miroman9364
approved these changes
Sep 21, 2023
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 27, 2023
This change updates the schema definitions to replace the `manifestVersion` property for resource manifests with the more canonical `$schema` keyword to reflect the changes from PowerShell#199.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 27, 2023
This change updates the schema definitions to replace the `manifestVersion` property for resource manifests with the more canonical `$schema` keyword to reflect the changes from PowerShell#199.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 27, 2023
This change updates the schema definitions to replace the `manifestVersion` property for resource manifests with the more canonical `$schema` keyword to reflect the changes from PowerShell#199.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 27, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 29, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 29, 2023
This change updates the schema definitions to replace the `manifestVersion` property for resource manifests with the more canonical `$schema` keyword to reflect the changes from PowerShell#199.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 29, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 30, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 30, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Change
manifestVersionin the resource manifest to$schemausing a URI instead of a semver. Added code to validate URI is a supported version by abstracting newimport_manifestfunction.PR Context
Fix #127