Skip to content

Improve documentation of ObjectModel#1531

Merged
kpodemski merged 7 commits intoPrestaShop:8.xfrom
thomasnares:objectmanager-doc
Nov 16, 2022
Merged

Improve documentation of ObjectModel#1531
kpodemski merged 7 commits intoPrestaShop:8.xfrom
thomasnares:objectmanager-doc

Conversation

@thomasnares
Copy link
Contributor

Needs this PR for Mermaid graphs to display properly : PrestaShop/ps-docs-theme#12

Questions Answers
Branch? 8.x
Description? Improve doc for ObjectManager, could be backported to 1.7.x with some modifications

@github-actions github-actions bot added the 8.x label Oct 4, 2022
@thomasnares thomasnares marked this pull request as draft October 5, 2022 12:23
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review, part 1.

thomasnares and others added 2 commits October 11, 2022 15:00
@thomasnares thomasnares marked this pull request as ready for review October 12, 2022 08:25
@thomasnares
Copy link
Contributor Author

up, can somebody review ?

@PululuK PululuK changed the title Improve documentation of ObjectManager Improve documentation of ObjectModel Oct 17, 2022
@thomasnares
Copy link
Contributor Author

🆙

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok to me @thomasnares

Please see if you can merge it (I approve this content) or if you wait one more review

@kpodemski
Copy link
Contributor

I'm merging it now, there are a few things that could be a bit more precise, but that is amazing work anyway! Thanks, @thomasnares

@kpodemski kpodemski merged commit c15d198 into PrestaShop:8.x Nov 16, 2022
@thomasnares
Copy link
Contributor Author

Be my guide @kpodemski 😄
point me out what i could improve when you have a few minutes 👍
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants