Improve documentation of ObjectModel#1531
Merged
kpodemski merged 7 commits intoPrestaShop:8.xfrom Nov 16, 2022
Merged
Conversation
Co-authored-by: Krystian Podemski <kpodemski@users.noreply.github.com>
Contributor
Author
|
up, can somebody review ? |
ObjectModel
Contributor
Author
|
🆙 |
matks
approved these changes
Nov 14, 2022
Contributor
matks
left a comment
There was a problem hiding this comment.
Looks Ok to me @thomasnares
Please see if you can merge it (I approve this content) or if you wait one more review
kpodemski
approved these changes
Nov 16, 2022
Contributor
|
I'm merging it now, there are a few things that could be a bit more precise, but that is amazing work anyway! Thanks, @thomasnares |
Contributor
Author
|
Be my guide @kpodemski 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs this PR for Mermaid graphs to display properly : PrestaShop/ps-docs-theme#12