Change mermaid dependencies and remove old ones#12
Merged
kpodemski merged 3 commits intoPrestaShop:mainfrom Oct 6, 2022
Merged
Change mermaid dependencies and remove old ones#12kpodemski merged 3 commits intoPrestaShop:mainfrom
kpodemski merged 3 commits intoPrestaShop:mainfrom
Conversation
|
@thomasnares using a public CDN isn't really respecting the privacy of the viewers of the documentation as the CDN can still gather some data on who is browsing the documentation, we removed every CDNs from the core for that reason, I think we should do the same for the documentation and keep the dependency local |
Contributor
Author
|
@NeOMakinG thanks, i fixed it |
kpodemski
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we keep a CDN hosted dependency ? let me know if we need to host our copy of mermaid.js