Skip to content

Change mermaid dependencies and remove old ones#12

Merged
kpodemski merged 3 commits intoPrestaShop:mainfrom
thomasnares:changeMermaidDependancies
Oct 6, 2022
Merged

Change mermaid dependencies and remove old ones#12
kpodemski merged 3 commits intoPrestaShop:mainfrom
thomasnares:changeMermaidDependancies

Conversation

@thomasnares
Copy link
Contributor

Questions Answers
Description? I changed mermaid dependencies to a more recent version (was unused for the moment, and i'm making mermaid flowcharts for new documentation.
Type? improvement
BC breaks? no
Deprecations? no
Possible impacts? no, Mermaid was not used for the moment

Should we keep a CDN hosted dependency ? let me know if we need to host our copy of mermaid.js

@NeOMakinG
Copy link

@thomasnares using a public CDN isn't really respecting the privacy of the viewers of the documentation as the CDN can still gather some data on who is browsing the documentation, we removed every CDNs from the core for that reason, I think we should do the same for the documentation and keep the dependency local

@thomasnares
Copy link
Contributor Author

@NeOMakinG thanks, i fixed it

@kpodemski kpodemski merged commit 5938758 into PrestaShop:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants