Added support to Ruby & VIM script languages#17
Added support to Ruby & VIM script languages#17samflores wants to merge 2 commits intoPrismJS:gh-pagesfrom samflores:gh-pages
Conversation
|
Hi there, Thank you so much for your effort and contribution! Would you be kind enough to fix this and submit a new pull request? :) Thanks!! |
|
Would still be nice to merge this. Not merging because of a couple of spaces that a decent text editor can fix in seconds is a little ridiculous. |
|
@mrbrdo You can extract the content and resubmit it as new PR (if @samflores is ok with that) |
|
My god, I just finished rebasing and squashing these commits to finally realise you're using tabs for indentation. That's retarded. And then you jump on the guy that's using sane conventions. You don't even have newlines at the end of files. Sigh, huge disappoint. |
|
I actually made another PR (#18) using the project conventions. Turns out it wasn't accepted too and I don't have the time to fix it right now. |
|
@mrbrdo: I’m sorry, but these are the conventions of the project. I have my reasons for using them but this is not the place for that debate. Also, if you’re disappointed in a project because of the indentation style and the lack of newlines at the end of files, I’ll happily live without your contributions. :) That said, I could have reviewed this by adding @samflores I’m sorry about that. I really want Ruby in Prism, so if I had the time to fix it myself, I would. :/ If you ever decide to work on it again, let me know if you need any help. |
|
I don't really care which conventions you use as far as whitespace goes, but if someone goes through a lot of work and is then turned down because of something like that, I don't consider it normal or nice at all. Considering it would not take you more than a few minutes to do it yourself, and since it is your decision to enforce this rules. A lot of text editors Ruby people use strip out trailing whitespace automatically and convert tabs to spaces too. In such a case it would be considerably easier and faster for you to do that than for someone with said editor. |
|
@mrbrdo The reason I used to reject PRs because of whitespace changes is that without |
I added a quick support to the languages I use most.