Added support to Ruby & VIM script languages#18
Closed
samflores wants to merge 5 commits into
Closed
Conversation
Member
|
Hi there, I was about to merge this right now (better late than never...) but I noticed a few things:
I'm really sorry it took me so long to review this. If you don't want to work on it any more, I understand. I hope it doesn't put you off future contributions. Thank you for your efforts! I'm closing this PR to keep things tidy, but feel free to reopen if you want to work on the issues above. |
Contributor
Author
|
I've got some time to work on this and have one question: do you prefer one PR per language or everything in a huge PR is fine? |
Member
|
Yay!! I’d prefer one PR per language. In general, the smaller PRs, the better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added a quick support to the languages I use most.
Sorry for the previous pull request. Hopefully I didn't break anything this time ;)