Fix interstitial not progressing to next task with web entry start events#1185
Merged
ryancooley merged 2 commits intodevelopfrom Feb 25, 2022
Merged
Fix interstitial not progressing to next task with web entry start events#1185ryancooley merged 2 commits intodevelopfrom
ryancooley merged 2 commits intodevelopfrom
Conversation
eiresendez
requested changes
Feb 17, 2022
Contributor
eiresendez
left a comment
There was a problem hiding this comment.
Hi Sanja - I tested the cases of Pull 1173 and there are conflicts, please watch the next videos for more information:
Testing in bugfix/FOUR-5414 branch:
https://user-images.githubusercontent.com/90741874/154565925-85eb454f-3abc-4201-bd6a-6c9644b8a1a9.mov
Testing in develop branch:
https://user-images.githubusercontent.com/90741874/154565957-bee013b8-ac07-40a1-b0e8-d012e4ea21a7.mov
eiresendez
approved these changes
Feb 18, 2022
Contributor
eiresendez
left a comment
There was a problem hiding this comment.
PR's changes correctly fix the issue with Web Entries. The problem I mentioned is not related to these changes.
ryancooley
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Ticket: FOUR-5414
Web entry Start Event with interstitial screen configured does not progress to the next assigned task. Console error appears
Cannot read properties of null (reading 'process_request_id')2. Add a form task and enable Web Entry
Expected behavior:
When selecting the submit button the interstitial displays then loads the next assigned task.
Actual behavior:
When selecting the submit button the interstitial screen continuously displays and never loads the next assigned task.
Solution
this.taskexists before retrieving theprocess_request_idkey.How to Test
Related Tickets & Packages
Code Review Checklist