Bugfix/FOUR-5159: Summary screen is not displayed in sub process

[agustinbusso]

Issue & Reproduction Steps

It was reported as a bug that subprocess inside a main process are not showing the summary screen in the subprocess, but that is not the correct behavior. It was fixed the issue related with the interstitial screen getting stuck and not getting
the next task.

• Steps to Reproduce:
• Create a process with the next configuration
• Start Event -> Task -> Sub Process -> End Event
• Create a sub process
• Add Start Event -> Task(Assign Screen Interstitial) -> End Event (Assign Summary Screen)
• Create a request
• Route to the sub process
• Open the sub process
• Complete the task

Solution

• Modified the flow to follow the next rules (For more clarify please watch the videos for the different scenarios):

1. Summary screen in a subprocess will show only if the process is running as standalone.
2. If a task has the option Display Next Assigned Task to Task Assignee checked, it will get the next task (if you are in a subprocess will get the next task in that subprocess, when the subprocess completed all the tasks will get the next task of the parent process)
3. If a task has the option Display Next Assigned Task to Task Assignee unchecked, will show the task list
4. If a subprocess is completed and no tasks in the main process, will show the summary screen of the main process

How to Test

Run e2e test cases in Task.spec.js
Please watch the following videos:

Case 1

Screen.Recording.2022-01-24.at.12.51.11.mov

Case 2

Screen.Recording.2022-01-24.at.12.56.50.mov

Case 3

Screen.Recording.2022-01-24.at.13.44.16.mov

Case 4

Screen.Recording.2022-01-24.at.16.26.59.mov

Case 5

Screen.Recording.2022-01-24.at.12.54.19.mov

Related Tickets & Packages

• FOUR-5159
• PR Processmaker

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[danloa]

the completed event with the requestId always will be sent and I don't know if it can have side effects. It seems that it will be better to put this line inside an "else" block of the above "if" condition, so

[agustinbusso]

If there is a parentRequest and task allows interstitial will return and not emit

[agustinbusso]

Added support for the case when there are no tasks in parent but there are tasks in subprocess

Screen.Recording.2022-01-26.at.12.01.31.mov