Fix Interstitial redirecting before a script task is completed#1196
Merged
ryancooley merged 2 commits into4.2.29-developfrom Mar 31, 2022
Merged
Fix Interstitial redirecting before a script task is completed#1196ryancooley merged 2 commits into4.2.29-developfrom
ryancooley merged 2 commits into4.2.29-developfrom
Conversation
agustinbusso
approved these changes
Mar 25, 2022
Contributor
agustinbusso
left a comment
There was a problem hiding this comment.
Fixed both tickets FOUR-5299 and FOUR-5806. Also tested the following scenarios:
Screen.Recording.2022-03-25.at.10.43.54.mov
Screen.Recording.2022-03-25.at.10.46.31.mov
Screen.Recording.2022-03-25.at.10.48.55.mov
Screen.Recording.2022-03-25.at.10.51.19.mov
Screen.Recording.2022-03-25.at.10.57.38.mov
There is a known issue (FOUR-5850) not related with this changes. When running a process with a single script task after the script completes, it not redirect to summary.
ryancooley
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Fixes Tickets
Reproduce:
Create a process with the next configuration

Put an interstitial in Form Task
Put a screen display in the end event
Create a request
Route to script to the process finished
Expected behavior:
Insterstitial should wait until the script task is completed.
Actual behavior:
Insterstitial completes BEFORE the script task is executed/completed.
Issue:
The issue was due to emitting the "completed" status of the current task if there was no assigned task to load next. Script tasks are not considered "tasks" that the user has access to, this caused the interstitial to complete before the script task had time to execute or be completed.
Solution
else ifconditional that checks if the process has a parent request via thethis.parentRequestvariable before emitting the "completed" status if no assigned task is loaded.How to Test
Related Tickets & Packages
Code Review Checklist