Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 3, 2021

Fixes #1539 .

Description

This PR changed the exception in SmartCacheDataset to warning and added docs.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 3, 2021

/black

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli merged commit fbab554 into Project-MONAI:master Feb 3, 2021
@Nic-Ma Nic-Ma deleted the 1539-add-warning-smartcache branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

smartcache should fallback to regular cachedataset when cache_num is large

2 participants