Skip to content

1539 Add warning message to SmartCache #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyli merged 4 commits into from
Feb 3, 2021
Merged

1539 Add warning message to SmartCache #1540

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42a45e0
Merge pull request #19 from Project-MONAI/master
Nic-Ma Feb 1, 2021
255d612
Merge pull request #22 from Project-MONAI/master
Nic-Ma Feb 3, 2021
601230d
[DLMED] update SmartCacheDataset docs and warning
Nic-Ma Feb 3, 2021
cdb67d6
isAlive => is_alive
wyli Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions monai/data/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,10 @@ class SmartCacheDataset(CacheDataset):
3. Call `update_cache()` before every epoch to replace training items.
4. Call `shutdown()` when training ends.

Note:
This replacement will not work if set the `multiprocessing_context` of DataLoader to `spawn`
or on windows(the default multiprocessing method is `spawn`) and set `num_workers` greater than 0 .

"""

def __init__(
Expand Down Expand Up @@ -601,7 +605,7 @@ def __init__(
if self._cache is None:
self._cache = self._fill_cache()
if self.cache_num >= len(data):
raise ValueError("cache_num must be smaller than dataset length to support replacement.")
warnings.warn("cache_num is greater or equal than dataset length, fall back to regular CacheDataset.")
if replace_rate <= 0:
raise ValueError("replace_rate must be greater than 0, otherwise, please use CacheDataset.")
self.num_replace_workers: int = num_replace_workers
Expand Down Expand Up @@ -637,7 +641,7 @@ def is_started(self):
"""
if self._replace_mgr is None:
return False
return self._replace_mgr.isAlive()
return self._replace_mgr.is_alive()

def start(self):
"""
Expand Down Expand Up @@ -688,7 +692,7 @@ def update_cache(self):
If the cache has been shutdown before, need to restart the `_replace_mgr` thread.

"""
if not self._replace_mgr.isAlive():
if not self._replace_mgr.is_alive():
self._restart()

# make sure update is done
Expand Down