Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented May 30, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #2284

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review May 30, 2021 15:16
@wyli
Copy link
Contributor Author

wyli commented May 30, 2021

the new feature works as expected:
https://github.com/Project-MONAI/MONAI/actions/runs/890487162
Canceling since a higher priority waiting request for 'build-2285' exists

so we don't need the previous workaround https://github.com/Project-MONAI/MONAI/blob/dev/.github/workflows/cleanup.yml

@wyli wyli requested review from Nic-Ma, ericspod and rijobro May 30, 2021 15:18
@wyli wyli added the CI/CD label May 30, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 2284-ci-duplicated branch from 6a38c80 to e652439 Compare May 30, 2021 15:28
@Nic-Ma Nic-Ma requested a review from madil90 May 30, 2021 15:28
@Nic-Ma
Copy link
Contributor

Nic-Ma commented May 30, 2021

Hi @madil90 ,

Could you please help review this PR as you are expert on related topics?

Thanks.

Copy link
Contributor

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concurrency in beta now. We may need to revisit this after it's stable.

@Nic-Ma Nic-Ma enabled auto-merge (squash) June 2, 2021 07:49
@rijobro
Copy link
Contributor

rijobro commented Jun 2, 2021

Looks great, thanks!

@Nic-Ma Nic-Ma merged commit e442051 into dev Jun 2, 2021
@Nic-Ma Nic-Ma deleted the 2284-ci-duplicated branch June 2, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecate cleanup-workflow in favor of github action concurrency

5 participants