Skip to content

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Sep 17, 2021

Description

Torch RandCropByPosNegLabel, RandCropByPosNegLabeld, RandCropByLabelClasses, RandCropByLabelClassesd

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

…abelClasses`, `RandCropByLabelClassesd`

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from Nic-Ma and wyli September 17, 2021 10:53
@rijobro rijobro enabled auto-merge (squash) September 17, 2021 15:18
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, to cache the foreground & background indices for pos / neg crop, could you please help also add Tensor backend for FgBgToIndices transform?

Thanks in advance.

@rijobro rijobro mentioned this pull request Sep 17, 2021
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Sep 19, 2021

I tested with the spleen fast training notebook, every thing seems fine.

Thanks.

@rijobro rijobro merged commit e2e2d08 into Project-MONAI:dev Sep 19, 2021
@rijobro rijobro deleted the torch_rand_crop_by branch September 22, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants