Skip to content

Conversation

@yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Oct 12, 2021

Signed-off-by: Yiheng Wang vennw@nvidia.com

Fixes #2186 (This PR implements grid distortion for 2D and 3D input, not for ND as required. The main reason is that grid distortion makes use of class Resample, which only support 2D and 3D input, and I think it is enough so far.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
pre-commit-ci bot and others added 5 commits October 14, 2021 09:00
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review October 15, 2021 08:11
@yiheng-wang-nv yiheng-wang-nv changed the title [WIP] 2186 add Grid Distortion transform 2186 add Grid Distortion transform Oct 15, 2021
@yiheng-wang-nv yiheng-wang-nv requested review from Nic-Ma and wyli October 15, 2021 08:36
@wyli
Copy link
Contributor

wyli commented Oct 15, 2021

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Oct 17, 2021

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit d538aa5 into Project-MONAI:dev Oct 18, 2021
@wyli wyli mentioned this pull request Oct 18, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GridDistortion data augmentation

2 participants