Skip to content

update rand grid distortions #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 5 commits into from
Oct 18, 2021
Merged

update rand grid distortions #3144

wyli merged 5 commits into from
Oct 18, 2021

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Oct 18, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

follow-up of #3117

  • adds figures
  • fixes dict transform issues

RandGridDistortiond

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
update rand grid distortion
280bf36 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update docs
89a5ba1 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 18, 2021

/build

@wyli wyli marked this pull request as ready for review October 18, 2021 13:30
Nic-Ma
Nic-Ma approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks.

yiheng-wang-nv
yiheng-wang-nv reviewed Oct 18, 2021
View reviewed changes
@wyli
update based on comments
6523bf6 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 18, 2021

/build

@wyli
fixes formatting and errors
c816034 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 18, 2021

/build

@wyli wyli enabled auto-merge (squash) October 18, 2021 16:53
@wyli
skip weights downloading
11f56b4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 18, 2021

/build

@wyli wyli merged commit 071879e into Project-MONAI:dev Oct 18, 2021
rijobro
rijobro reviewed Oct 20, 2021
View reviewed changes
@wyli wyli mentioned this pull request Oct 20, 2021
Merged
7 tasks
@wyli wyli deleted the distortion-fig branch April 27, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro rijobro left review comments

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv left review comments

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wyli @Nic-Ma @rijobro @yiheng-wang-nv