3346 Simplify AsDiscrete transform

[Nic-Ma]

Fixes #3346 .

Description

This PR simplified AsDiscrete according to the feedback.

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

Hi @wyli @ericspod ,

As we changed many args of the transform, I feel it's very confusing to maintain the deprecated args in it, so I deleted the deprecated args directly. Can we accept this slightly breaking change in v0.8?

Thanks.

[Nic-Ma]

/black

[Nic-Ma]

/build

[ericspod]

We should use the deprecated decorators to mark removed arguments and document it in the docstring, that should be enough for breaking changes though I know my code a lot of the tutorials will need changing. Raising exceptions for wrong value types would help as well. We're going to be changing other transforms a lot as well before 1.0 so I don't think this will be the only thing.

[Nic-Ma]

Hi @wyli @ericspod ,

Thanks for your review and comments.
I updated the PR to add the deprecated information and raise error, could you please help review it again?

Thanks in advance.

[Nic-Ma]

/black

[Nic-Ma]

/build

[Nic-Ma]

/build

[Nic-Ma]

/black

[Nic-Ma]

/build

[Nic-Ma]

/build