Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Nov 19, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

follow up of #3352

Description

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from Nic-Ma November 19, 2021 13:47
@wyli
Copy link
Contributor Author

wyli commented Nov 19, 2021

Hi @Nic-Ma, this changes the valueerror of using deprecated arguments to a warning, I think it's needed for 0.8 to avoid too much broken use cases.

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please double confirm the compatibility with some tutorials or examples.

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Nov 19, 2021

/build

@wyli
Copy link
Contributor Author

wyli commented Nov 19, 2021

@wyli wyli merged commit e36fbd3 into Project-MONAI:dev Nov 19, 2021
@wyli wyli deleted the back-asdiscrete branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants