Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 6, 2020

Hi All,

This PR implemented the common inference logic of sliding window method #39 .
Also added image padder transform(pad to end).

Could you please help review it?
Thanks in advance.

I already added unit tests for them and verified locally:

_test_conv1 (tests.test_convolutions.TestConvolution2D) ... ok
test_conv_only1 (tests.test_convolutions.TestConvolution2D) ... ok
test_dilation1 (tests.test_convolutions.TestConvolution2D) ... ok
test_dropout1 (tests.test_convolutions.TestConvolution2D) ... ok
test_stride1 (tests.test_convolutions.TestConvolution2D) ... ok
test_transpose1 (tests.test_convolutions.TestConvolution2D) ... ok
test_transpose2 (tests.test_convolutions.TestConvolution2D) ... ok
test_conv_only1 (tests.test_convolutions.TestResidualUnit2D) ... ok
test_dilation1 (tests.test_convolutions.TestResidualUnit2D) ... ok
test_dropout1 (tests.test_convolutions.TestResidualUnit2D) ... ok
test_stride1 (tests.test_convolutions.TestResidualUnit2D) ... ok
test_shape_0 (tests.test_dice_loss.TestDiceLoss) ... ok
test_shape_1 (tests.test_dice_loss.TestDiceLoss) ... ok
test_image_end_pad_shape_0 (tests.test_image_end_padder.TestImageEndPadder) ... ok
test_image_normalizer_default (tests.test_intensity_normalizer.IntensityNormTestCase) ... ok
test_sliding_window_default (tests.test_sliding_window_inference.TestSlidingWindowInference) ... ok
test_shape_0 (tests.test_unet.TestUNET) ... ok
test_shape_1 (tests.test_unet.TestUNET) ... ok
test_shape_2 (tests.test_unet.TestUNET) ... ok


Ran 19 tests in 5.266s

OK_

The CI test error is because runner can't find GPU:
Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver
Need @IsaacYangSLA to help on CI config.
Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 6, 2020

Hi @IsaacYangSLA ,

I found the "build" CI test failed because runner can't find GPU driver.
Could you please help take a look?
Thanks in advance.

@wyli wyli mentioned this pull request Feb 6, 2020
5 tasks
@Nic-Ma Nic-Ma changed the title 39-sliding-window-inference 39 sliding window inference Feb 7, 2020
@wyli
Copy link
Contributor

wyli commented Feb 7, 2020

all commits from this PR are merged into #56 please review #56 instead

@wyli wyli closed this Feb 7, 2020
@wyli wyli deleted the 39-sliding-window-inference branch May 21, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants