39 sliding window workflow #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
commented
Feb 6, 2020
wyli
commented
Feb 7, 2020
Nic-Ma
reviewed
Feb 7, 2020
Nic-Ma
reviewed
Feb 7, 2020
This was referenced Feb 7, 2020
Closed
wyli
commented
Feb 7, 2020
ericspod
reviewed
Feb 7, 2020
ericspod
reviewed
Feb 7, 2020
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
I commented on iter_dense_patch_slices
* Fix canonical transformation bug in nifti writer. * fixes nifti reader/writer's as_closest_canonical option, adds unit tests Co-authored-by: Wenqi Li <wenqi.li@ucl.ac.uk>
Contributor
Author
|
@ericspod I think the PR is ready, could you please review? after merging this, we could have another iteration to refactor |
ericspod
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 #6 #5 .
Description
combining PR #52 #53 #57 implementing a sliding window inference workflow in
examples/unet_inference_3d.pyTODOs
- unit test for event handler:monai/application/handlers/segmentation_saver.py- integration test for the workflow(advanced testing tasks should be part of #17)
discussion of the niftidataset changes for metadata
monai/data/readers/niftireader.pyimplement a model checkpoint loading event handler?
Status
Ready
Types of changes