39 nifti writer #53
Closed
39 nifti writer #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @IsaacYangSLA , I found 2 CI issues in this PR:
Could you please help take a look? |
ericspod
approved these changes
Feb 6, 2020
| affine = np.eye(4) | ||
|
|
||
| if revert_canonical: | ||
| codes = nib.orientations.axcodes2ornt(nib.orientations.aff2axcodes(np.linalg.inv(affine))) |
Member
There was a problem hiding this comment.
Does np.linalg.inv(affine) actually give up the orientation we expect of the original? If the original's axis codes were LAS they would become RAS when converted to canonical, but doesn't this line turn RAS into LPI?
Contributor
Author
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
This PR implemented the tool API to write model output data into Nifti format image #39 .
We can call it when evaluation and validation examples are ready.
Could you please help review it?
Thanks.