Skip to content

Fix canonical transformation bug in nifti writer. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 3 commits into from
Feb 13, 2020
Merged

Fix canonical transformation bug in nifti writer. #74

wyli merged 3 commits into from
Feb 13, 2020

Conversation

@madil90
Copy link
Contributor

@madil90 madil90 commented Feb 13, 2020

Description

Fix closest_canonical calculation in niftiwriter.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@madil90 madil90 requested review from ericspod and wyli and removed request for ericspod February 13, 2020 04:15
This was referenced Feb 13, 2020
Merged
Closed
@wyli wyli requested a review from ericspod February 13, 2020 09:08
wyli
wyli reviewed Feb 13, 2020
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madil90 revised the reorientation and added test, hopefully it's a more intuitive solution and I believe it's good enough for now...

@wyli wyli merged commit 064e6b3 into 39-sliding-window-workflow Feb 13, 2020
@wyli wyli deleted the 56-nifti-canonical branch April 6, 2020 13:36
wyli pushed a commit that referenced this pull request Apr 9, 2021
@Nic-Ma
Merge pull request #74 from Project-MONAI/master
dea28cf 
merge master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli left review comments

@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madil90 @wyli