Classification post-process for HoVerNet #5462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
Nic-Ma
reviewed
Nov 3, 2022
Signed-off-by: KumoLiu <yunl@nvidia.com>
… into postprocess-hovernet Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
2 tasks
6 tasks
Signed-off-by: KumoLiu <yunl@nvidia.com>
… into postprocess-hovernet
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
bhashemian
reviewed
Nov 8, 2022
Member
bhashemian
left a comment
bhashemian
left a comment
There was a problem hiding this comment.
Hi @KumoLiu, overall it looks great! I just left few comments.
Signed-off-by: KumoLiu <yunl@nvidia.com>
… into postprocess-hovernet
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Nic-Ma
approved these changes
Nov 14, 2022
KumoLiu
changed the title
bhashemian
reviewed
Nov 14, 2022
Member
There was a problem hiding this comment.
@KumoLiu it looks great now! Just left few comments regarding the namings.
Signed-off-by: yunliu <yunl@nvidia.com>
bhashemian
approved these changes
Nov 15, 2022
Contributor
|
/black |
Contributor
|
/build |
bhashemian
added a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
Signed-off-by: KumoLiu <yunl@nvidia.com> Fixes Project-MONAI#5180. ### Description For the post-process in HoVerNet, now we have PR Project-MONAI#5173 to process the segmentation output(which has been merged) and PR Project-MONAI#5186 to process the classification output(which is under review now). We want a whole transform containing these two components which can be easily used in the MONAI model zoo bundle. Here has a draft version of how to combine these components, if anyone has any suggestions, please feel free to take it out. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: KumoLiu <yunl@nvidia.com> Signed-off-by: yunliu <yunl@nvidia.com> Co-authored-by: Behrooz Hashemian <3968947+drbeh@users.noreply.github.com> Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: KumoLiu yunl@nvidia.com
Fixes #5180.
Description
For the post-process in HoVerNet, now we have PR #5173 to process the segmentation output(which has been merged) and PR #5186 to process the classification output(which is under review now). We want a whole transform containing these two components which can be easily used in the MONAI model zoo bundle. Here has a draft version of how to combine these components, if anyone has any suggestions, please feel free to take it out.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.