Skip to content

3803 lncc loss fix and warp to cache regular grid #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 5 commits into from
Nov 7, 2022
Merged

3803 lncc loss fix and warp to cache regular grid #5473

wyli merged 5 commits into from
Nov 7, 2022

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Nov 4, 2022

Fixes #3803

Description

  • fixes lncc loss
  • adds a cache of the reference grid for warp

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits November 4, 2022 17:13
@wyli
fixes lncc large kernel issue
8e6cd6a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update docs
fa2b193 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
caching grid
b9e6622 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli mentioned this pull request Nov 4, 2022
Closed
@wyli wyli added this to the Registration bundle [P0 v1.1] milestone Nov 4, 2022
wyli and others added 2 commits November 4, 2022 17:51
@wyli
Merge branch 'dev' into 3803-lncc
9a5f1f8
@wyli
flake8
587d534 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@ebrahimebrahim
Copy link
Contributor

ebrahimebrahim commented Nov 4, 2022

Really happy to see this!

Setting the default smooth_nr to 0 agrees with some earlier observations on this issue

@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2022

/build

@wyli wyli enabled auto-merge (squash) November 7, 2022 09:32
@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2022

/build

5 similar comments
@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2022

/build

@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2022

/build

@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2022

/build

@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2022

/build

@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2022

/build

@wyli wyli merged commit d745606 into Project-MONAI:dev Nov 7, 2022
@wyli wyli self-assigned this Nov 7, 2022
@wyli wyli deleted the 3803-lncc branch December 13, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

@rijobro rijobro Awaiting requested review from rijobro

@kate-sann5100 kate-sann5100 Awaiting requested review from kate-sann5100

Assignees

@wyli wyli

Labels

None yet

Projects

No open projects
MONAI v1.1
Status: Done

Milestone

Registration bundle [P0 v1.1]

Development

Successfully merging this pull request may close these issues.

LNCC loss instability for large kernel size

3 participants

@wyli @ebrahimebrahim @KumoLiu