feat(SABlock): access to the attn matrix #6271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Project-MONAI#6223 . ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Ben Murray <ben.murray@gmail.com> Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
Fixes Project-MONAI#6255 ### Description upgrade pytorch to 23.03 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com> Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
for more information, see https://pre-commit.ci Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
a-parida12
force-pushed
the
attn-block-access
branch
from
0e25c63 to
4444b19
Compare
wyli
approved these changes
Apr 3, 2023
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
looks good to me cc @yiheng-wang-nv @binliunls @Nic-Ma
Contributor
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
auto-merge was automatically disabled
April 3, 2023 19:57
Merge queue setting changed
Contributor
|
this doesn't seem to work, I'll revert this change |
wyli
added a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6032 .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.