Skip to content

Fix MONAILabel-related bugs in dtype conversion and inverse of Spacing #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyli merged 5 commits into from
Apr 11, 2023
Merged

Fix MONAILabel-related bugs in dtype conversion and inverse of Spacing #6315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77c41a8
Restore 'src_affine' for repeated inverse
liamchalcroft Apr 6, 2023
7dd6146
Add split to dtype string for unwanted prefix
liamchalcroft Apr 6, 2023
f06d0e5
Fix to match formatting in type_conversion
liamchalcroft Apr 6, 2023
59e6dad
DCO Remediation Commit for Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>
liamchalcroft Apr 6, 2023
669f2e6
Merge branch 'dev' into dev
liamchalcroft Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions monai/transforms/spatial/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ def inverse(self, data: torch.Tensor) -> torch.Tensor:
with self.trace_transform(False):
# we can't use `self.__call__` in case a child class calls this inverse.
out: torch.Tensor = SpatialResample.__call__(self, data, **kw_args)
kw_args["src_affine"] = kw_args.get("dst_affine")
return out


Expand Down
2 changes: 1 addition & 1 deletion monai/utils/type_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

def get_numpy_dtype_from_string(dtype: str) -> np.dtype:
"""Get a numpy dtype (e.g., `np.float32`) from its string (e.g., `"float32"`)."""
return np.empty([], dtype=dtype).dtype
return np.empty([], dtype=str(dtype).split(".")[-1]).dtype


def get_torch_dtype_from_string(dtype: str) -> torch.dtype:
Expand Down