Fix MONAILabel-related bugs in dtype conversion and inverse of Spacing #6315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I, Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>, hereby add my Signed-off-by to this commit: 77c41a8 I, Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>, hereby add my Signed-off-by to this commit: 7dd6146 I, Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>, hereby add my Signed-off-by to this commit: f06d0e5 Signed-off-by: Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>
wyli
approved these changes
Apr 11, 2023
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, looks good to me, I'll add the unit tests before merging into dev
wyli
added a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: monai-bot <monai.miccai2019@gmail.com> (closing #6318 closing #6319 auto3dseg) (closing #6314 closing #6315 dtype conversion) (closing #6326 closing #6329 metatensor clone) (including a workaround for #6311) --------- Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com> Signed-off-by: Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk> Signed-off-by: Wenqi Li <wenqil@nvidia.com> Signed-off-by: KumoLiu <yunl@nvidia.com> Co-authored-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com> Co-authored-by: Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk> Co-authored-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues relating to dtype and src_affine in inverse of spatial transforms. Issue found to occur when inverse for a given function is required many times, e.g. for iterative updates in interactive segmentation. Related issue #6314