Skip to content

Conversation

@mingxin-zheng
Copy link
Contributor

Fixes #6318 .

Description

  • Add a new key AlgoKeys
  • Replace all existing usage of AlgoEnsembleKeys

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • In-line docstrings updated.

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Copy link
Collaborator

@myron myron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks

@mingxin-zheng
Copy link
Contributor Author

Hi @wyli @Nic-Ma , can we consider merge this? Thanks!

@wyli
Copy link
Contributor

wyli commented Apr 11, 2023

/build

@wyli
Copy link
Contributor

wyli commented Apr 11, 2023

/integration-test

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyli wyli changed the base branch from dev to auto-update April 11, 2023 07:45
@wyli wyli merged commit 9cb17ae into Project-MONAI:auto-update Apr 11, 2023
wyli added a commit that referenced this pull request Apr 11, 2023
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

(closing #6318 closing #6319 auto3dseg)
(closing #6314 closing #6315 dtype conversion)
(closing #6326 closing #6329 metatensor clone)
(including a workaround for #6311)

---------

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Co-authored-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Co-authored-by: Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
@mingxin-zheng mingxin-zheng deleted the fix-6318-key branch April 12, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate Auto3DSeg AlgoEnsembleKeys by AlgoKeys

3 participants